From e534e80de01afbe7b4b1ac0a89f4aba7b345944f Mon Sep 17 00:00:00 2001 From: Rohit Nayak Date: Sat, 8 Feb 2025 21:52:03 +0100 Subject: [PATCH] Add additional logs for failure Signed-off-by: Rohit Nayak --- .../tabletmanager/vreplication/replicator_plan.go | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go b/go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go index 95e4c98dda9..cf94df0f48b 100644 --- a/go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go +++ b/go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go @@ -34,6 +34,7 @@ import ( "vitess.io/vitess/go/sqlescape" "vitess.io/vitess/go/sqltypes" "vitess.io/vitess/go/vt/binlog/binlogplayer" + "vitess.io/vitess/go/vt/log" "vitess.io/vitess/go/vt/sqlparser" "vitess.io/vitess/go/vt/vterrors" "vitess.io/vitess/go/vt/vtgate/evalengine" @@ -725,8 +726,17 @@ func (tp *TablePlan) appendFromRow(buf *bytes2.Buffer, row *querypb.Row) error { len(tp.Fields), len(bindLocations)) } if len(row.Lengths) < len(tp.Fields) { - return vterrors.Errorf(vtrpcpb.Code_INTERNAL, "wrong number of lengths: got %d lengths for %d fields", - len(row.Lengths), len(tp.Fields)) + // temporary logs added for debugging a production issue for which we have not yet found root cause. + log.Warningf("appendFromRow: wrong number of lengths for table %s: got %d lengths for %d fields", + tp.TablePlanBuilder.name, len(row.Lengths), len(tp.Fields)) + for i, fld := range tp.Fields { + log.Warningf("appendFromRow: field:: %d:%s/%s", i, fld.Table, fld.Name) + } + for i, length := range row.Lengths { + log.Warningf("appendFromRow: col length:: %d:%d", i, length) + } + return vterrors.Errorf(vtrpcpb.Code_INTERNAL, "wrong number of lengths for table %s: got %d lengths for %d fields", + tp.TablePlanBuilder.name, len(row.Lengths), len(tp.Fields)) } // Bind field values to locations.