From c2cfa0e206d76c3cf0e88cb807dc245d3a880cd4 Mon Sep 17 00:00:00 2001 From: Rohit Nayak Date: Tue, 11 Feb 2025 21:47:54 +0100 Subject: [PATCH] Disable parallel inserts for atomic copies for now Signed-off-by: Rohit Nayak --- go/vt/vttablet/tabletmanager/vreplication/vcopier_atomic.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/go/vt/vttablet/tabletmanager/vreplication/vcopier_atomic.go b/go/vt/vttablet/tabletmanager/vreplication/vcopier_atomic.go index bfcbd4960c3..1e3892c0f05 100644 --- a/go/vt/vttablet/tabletmanager/vreplication/vcopier_atomic.go +++ b/go/vt/vttablet/tabletmanager/vreplication/vcopier_atomic.go @@ -84,6 +84,11 @@ func (vc *vcopier) copyAll(ctx context.Context, settings binlogplayer.VRSettings defer rowsCopiedTicker.Stop() parallelism := int(math.Max(1, float64(vc.vr.workflowConfig.ParallelInsertWorkers))) + // For now do not support concurrent inserts for atomic copies. + if parallelism > 1 { + parallelism = 1 + log.Infof("Disabling concurrent inserts for atomic copies") + } copyWorkerFactory := vc.newCopyWorkerFactory(parallelism) var copyWorkQueue *vcopierCopyWorkQueue