From 7949d15b013b093c84129b3a853f937c246a4a7e Mon Sep 17 00:00:00 2001 From: Harshit Gangal Date: Thu, 27 Feb 2025 20:18:15 +0530 Subject: [PATCH] perf: avoid extra allocs by restricting normalization for certain SQLNode Signed-off-by: Harshit Gangal --- go/vt/sqlparser/normalizer.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/go/vt/sqlparser/normalizer.go b/go/vt/sqlparser/normalizer.go index 23fd707c00d..c0d0d8000ed 100644 --- a/go/vt/sqlparser/normalizer.go +++ b/go/vt/sqlparser/normalizer.go @@ -173,7 +173,9 @@ func (nz *normalizer) determineQueryRewriteStrategy(in Statement) { // It handles normalization logic based on node types. func (nz *normalizer) walkDown(node, _ SQLNode) bool { switch node := node.(type) { - case *PrepareStmt, *ExecuteStmt: + case *Begin, *Commit, *Rollback, *Savepoint, *SRollback, *Release, *OtherAdmin, *Analyze, + *PrepareStmt, *ExecuteStmt, *FramePoint, *ColName, TableName, *ConvertType: + // These statement do not need normalizing return false case *AssignmentExpr: nz.err = vterrors.VT12001("Assignment expression")