From 3e1f28ea01653c2073a49fd6a6002683856549af Mon Sep 17 00:00:00 2001 From: deepthi Date: Thu, 20 Feb 2025 19:01:28 -0800 Subject: [PATCH] check always-on heartbeat config before on-demand Signed-off-by: deepthi --- go/vt/vttablet/tabletserver/repltracker/writer.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/go/vt/vttablet/tabletserver/repltracker/writer.go b/go/vt/vttablet/tabletserver/repltracker/writer.go index 11492fa92e4..c5173e1ec5a 100644 --- a/go/vt/vttablet/tabletserver/repltracker/writer.go +++ b/go/vt/vttablet/tabletserver/repltracker/writer.go @@ -98,15 +98,15 @@ func newHeartbeatWriter(env tabletenv.Env, alias *topodatapb.TabletAlias) *heart configType := HeartbeatConfigTypeNone onDemandDuration := defaultOnDemandDuration switch { + case config.ReplicationTracker.Mode == tabletenv.Heartbeat: + configType = HeartbeatConfigTypeAlways + onDemandDuration = 0 case config.ReplicationTracker.HeartbeatOnDemand > 0: configType = HeartbeatConfigTypeOnDemand onDemandDuration = config.ReplicationTracker.HeartbeatOnDemand if onDemandDuration < minimalOnDemandDuration { onDemandDuration = minimalOnDemandDuration } - case config.ReplicationTracker.Mode == tabletenv.Heartbeat: - configType = HeartbeatConfigTypeAlways - onDemandDuration = 0 } heartbeatInterval := config.ReplicationTracker.HeartbeatInterval if heartbeatInterval == 0 {