check always-on heartbeat config before on-demand

Signed-off-by: deepthi <deepthi@planetscale.com>
planetscale · Feb 21, 2025 · 3e1f28e · 3e1f28e
1 parent c9c227d
commit 3e1f28e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/go/vt/vttablet/tabletserver/repltracker/writer.go b/go/vt/vttablet/tabletserver/repltracker/writer.go
@@ -98,15 +98,15 @@ func newHeartbeatWriter(env tabletenv.Env, alias *topodatapb.TabletAlias) *heart
 	configType := HeartbeatConfigTypeNone
 	onDemandDuration := defaultOnDemandDuration
 	switch {
+	case config.ReplicationTracker.Mode == tabletenv.Heartbeat:
+		configType = HeartbeatConfigTypeAlways
+		onDemandDuration = 0
 	case config.ReplicationTracker.HeartbeatOnDemand > 0:
 		configType = HeartbeatConfigTypeOnDemand
 		onDemandDuration = config.ReplicationTracker.HeartbeatOnDemand
 		if onDemandDuration < minimalOnDemandDuration {
 			onDemandDuration = minimalOnDemandDuration
 		}
-	case config.ReplicationTracker.Mode == tabletenv.Heartbeat:
-		configType = HeartbeatConfigTypeAlways
-		onDemandDuration = 0
 	}
 	heartbeatInterval := config.ReplicationTracker.HeartbeatInterval
 	if heartbeatInterval == 0 {