Address review comments. Run parallel insert on extended TestFKExt an…

…d regular on TestFKWorkflow

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

go/test/endtoend/vreplication/fk_ext_test.go

@@ -86,7 +86,10 @@ func TestFKExt(t *testing.T) {
 	setSidecarDBName("_vt")
 
 	// Ensure that there are multiple copy phase cycles per table.
-	extraVTTabletArgs = append(extraVTTabletArgs, "--vstream_packet_size=256", "--queryserver-config-schema-change-signal")
+	extraVTTabletArgs = append(extraVTTabletArgs,
+		"--vstream_packet_size=256",
+		"--queryserver-config-schema-change-signal",
+		parallelInsertWorkers)
 	extraVTGateArgs = append(extraVTGateArgs, "--schema_change_signal=true", "--planner-version", "Gen4")
 	defer func() { extraVTTabletArgs = nil }()
 	initFKExtConfig(t)

go/test/endtoend/vreplication/fk_test.go

@@ -43,7 +43,6 @@ func TestFKWorkflow(t *testing.T) {
 	extraVTTabletArgs = []string{
 		// Ensure that there are multiple copy phase cycles per table.
 		"--vstream_packet_size=256",
-		parallelInsertWorkers,
 	}
 	defer func() { extraVTTabletArgs = nil }()
 

go/vt/vttablet/tabletmanager/vreplication/vcopier_atomic.go

@@ -201,11 +201,10 @@ func (vc *vcopier) copyAll(ctx context.Context, settings binlogplayer.VRSettings
 		// Prepare a vcopierCopyTask for the current batch of work.
 		currCh := make(chan *vcopierCopyTaskResult, 1)
 
-		resp2 := resp
 		if parallelism > 1 {
-			resp2 = resp.CloneVT()
+			resp = resp.CloneVT()
 		}
-		currT := newVCopierCopyTask(newVCopierCopyTaskArgs(resp2.Rows, resp2.Lastpk))
+		currT := newVCopierCopyTask(newVCopierCopyTaskArgs(resp.Rows, resp.Lastpk))
 
 		// Send result to the global resultCh and currCh. resultCh is used by
 		// the loop to return results to VStreamRows. currCh will be used to