Code review fixes for topology_spread_constraints

Signed-off-by: Aurel Canciu <aurel.canciu@nexhealth.com>
planetscale · Oct 16, 2024 · e600832 · e600832
1 parent 257e25b
commit e600832
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/pkg/operator/contenthash/topology_spread_constraints.go b/pkg/operator/contenthash/topology_spread_constraints.go
@@ -20,7 +20,6 @@ package contenthash
 import (
 	"crypto/md5"
 	"encoding/hex"
-	"fmt"
 	"strings"
 
 	corev1 "k8s.io/api/core/v1"
@@ -45,11 +44,9 @@ func TopologySpreadConstraints(in []corev1.TopologySpreadConstraint) string {
 		}
 		writeStringHash(h, StringMap(labelSelectors))
 		writeStringHash(h, strings.Join(tsc.MatchLabelKeys, ""))
-		minDomainsSeconds := "nil"
 		if tsc.MinDomains != nil {
-			minDomainsSeconds = fmt.Sprint(*tsc.MinDomains)
+			writeStringHash(h, string(*tsc.MinDomains))
 		}
-		writeStringHash(h, minDomainsSeconds)
 		if tsc.NodeAffinityPolicy != nil {
 			writeStringHash(h, string(*tsc.NodeAffinityPolicy))
 		}

diff --git a/pkg/operator/contenthash/topology_spread_constraints_test.go b/pkg/operator/contenthash/topology_spread_constraints_test.go
@@ -1,5 +1,5 @@
 /*
-Copyright 2020 PlanetScale Inc.
+Copyright 2024 PlanetScale Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.