Enable null checker on Libplanet project's top-level files #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
requested review from
longfin,
limebell,
earlbread,
riemannulus and
moreal
to check new syntaxes introduced since C# 8. [changelog skip]
dahlia
force-pushed
the
null-checker
branch
from
4129b12 to
d823b02
Compare
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 88.33% 88.38% +0.04%
==========================================
Files 331 331
Lines 30232 30234 +2
==========================================
+ Hits 26705 26721 +16
+ Misses 1922 1903 -19
- Partials 1605 1610 +5
|
|
@planetarium/libplanet Could you review this? |
riemannulus
approved these changes
Sep 29, 2020
moreal
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables null checker on Libplanet project's top-level files to contribute to #458.
Also upgraded StyleCop.Analyzers to 1.2.0-beta.205 in order to avoid DotNetAnalyzers/StyleCopAnalyzers#2927.
Total files:
Files that enable null checker (43%):
Note that it was before (39%):