Release 0.12.0 #258

U-lis · 2024-03-26T11:49:58Z

Query optimization
Cache avatar level to DB
Add all product list API with caching
Consume valid purchases

Backmerge 0.11.0 to development

- Optimize product list query - Get all item, favs at once - Optimize purchase history query - Get all purchase history and check limitation at once

- Move admin page views(showing html) to `views` router - Update related routes

Update product/purchase APIs

Refactoring views

- Because debug toolbar is not installed in production env. - So import in global scope must raise error

Cache avatar's level into DB and use checking required level

Import debugtoolbar inside if clause

pull changes from dev to release

Consume purchase first when its valid

pull-request-quantifier-deprecated · 2024-03-26T12:10:46Z

This PR has 344 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +251 -93
Percentile : 74.4%

Total files changed: 14

Change summary by file extension:
.py : +233 -77
.svelte : +3 -3
.toml : +15 -13

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-03-26T12:59:35Z

This PR has 344 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +251 -93
Percentile : 74.4%

Total files changed: 14

Change summary by file extension:
.py : +233 -77
.svelte : +3 -3
.toml : +15 -13

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-03-26T13:18:05Z

This PR has 355 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +261 -94
Percentile : 75.5%

Total files changed: 15

Change summary by file extension:
.md : +9 -0
.py : +233 -77
.svelte : +3 -3
.toml : +16 -14

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

U-lis added 30 commits March 15, 2024 09:15

Record error message to DB

e01c305

Update packages

d6b53bc

Merge pull request #245 from planetarium/release/0.11.0

d344cf3

Backmerge 0.11.0 to development

Add debug-toolbar for optimization

8ee48ad

Optimize queries

6fee136

- Optimize product list query - Get all item, favs at once - Optimize purchase history query - Get all purchase history and check limitation at once

Merge branch 'development' into bugfix/product-api

203c671

Remove unused codes

dac0bd8

Add missing query clauses

d9c5ff0

Refactoring views

22ce15c

- Move admin page views(showing html) to `views` router - Update related routes

Optimize query using group_by to get purhcase history

baa6dd9

Add all product list API

08baa8f

Default of buyable is False

1bc47c4

Remove order_by for faster query

50c98f4

Add AvatarLevel model to cache level

ce1e4ad

Create migrate script

7caa704

Use cached data while checking required level

fdf5903

Add cache library

8ae43c0

Add cache to all product list API

905b256

Merge pull request #250 from planetarium/bugfix/product-api

8162b9b

Update product/purchase APIs

Merge branch 'development' into feature/move-views

1692a31

Merge pull request #251 from planetarium/feature/move-views

12ecdd4

Refactoring views

Merge branch 'development' into feature/backup-required-level

4c323c2

Import debugtoolbar inside if clause

2a764a3

- Because debug toolbar is not installed in production env. - So import in global scope must raise error

Merge pull request #252 from planetarium/feature/backup-required-level

934cc1e

Cache avatar's level into DB and use checking required level

Merge pull request #253 from planetarium/bugfix/debug-toolbar

2422d6b

Import debugtoolbar inside if clause

Merge pull request #254 from planetarium/development

287fb5e

pull changes from dev to release

Consume valid purchases

8a6d3eb

Fix wrong error message

4c90eb6

Remove unused codes

2cc8b07

Merge pull request #256 from planetarium/bugfix/auto-refund

26ce25b

Consume purchase first when its valid

U-lis temporarily deployed to development March 26, 2024 11:50 — with GitHub Actions Inactive

pull-request-quantifier-deprecated bot added the Large label Mar 26, 2024

Merge branch 'main' into release/0.12.0

7fa42dc

U-lis temporarily deployed to internal March 26, 2024 12:59 — with GitHub Actions Inactive

U-lis temporarily deployed to development March 26, 2024 12:59 — with GitHub Actions Inactive

U-lis temporarily deployed to internal March 26, 2024 13:01 — with GitHub Actions Inactive

U-lis temporarily deployed to internal March 26, 2024 13:06 — with GitHub Actions Inactive

Update version to 0.12.0

55a04f4

U-lis temporarily deployed to internal March 26, 2024 13:18 — with GitHub Actions Inactive

U-lis temporarily deployed to development March 26, 2024 13:18 — with GitHub Actions Inactive

U-lis temporarily deployed to internal March 26, 2024 13:20 — with GitHub Actions Inactive

U-lis temporarily deployed to internal March 26, 2024 13:24 — with GitHub Actions Inactive

U-lis merged commit e7408fd into main Mar 26, 2024
30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 0.12.0 #258

Release 0.12.0 #258

U-lis commented Mar 26, 2024

pull-request-quantifier-deprecated bot commented Mar 26, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 26, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 26, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

Release 0.12.0 #258

Release 0.12.0 #258

Conversation

U-lis commented Mar 26, 2024

pull-request-quantifier-deprecated bot commented Mar 26, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 26, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 26, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output