Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lib9c models #216

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Refactor lib9c models #216

merged 9 commits into from
Jan 15, 2024

Conversation

U-lis
Copy link
Collaborator

@U-lis U-lis commented Jan 11, 2024

  • Create Address model
  • Create Currency model
  • Create FungibleAssteValue model

@U-lis U-lis added the enhancement New feature or request label Jan 11, 2024
@U-lis U-lis requested review from ipdae and riemannulus January 11, 2024 08:25
@U-lis U-lis self-assigned this Jan 11, 2024
return {
"decimalPlaces": b'\x00',
"minters": None,
"ticker": ticker.upper(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mead 같은 케이스를 생각하면 ticker는 밖에서 정하고 보내주는게 좋을것같습니다.

"b3cbca0e64aeb4b5b861047fe1db5a1bec1c241f",
])
def test_address(addr):
address = Address(addr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValueError 발생 케이스를 추가하면 좋을것 같습니다.

This PR has 335 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +261 -74
Percentile : 73.5%

Total files changed: 14

Change summary by file extension:
.py : +261 -74

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Copy link
Member

@ipdae ipdae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실제 claimItems 액션을 생성하는건 이후 pr에서 진행되는건가요? (plainValue가 제대로 셋안되는것처럼 보여서)

@U-lis
Copy link
Collaborator Author

U-lis commented Jan 15, 2024

실제 claimItems 액션을 생성하는건 이후 pr에서 진행되는건가요? (plainValue가 제대로 셋안되는것처럼 보여서)

네 action 만드는건 이 branch 에서 이어서 commit 쌓을 예정입니다.

@U-lis U-lis merged commit 6301a7e into development Jan 15, 2024
10 checks passed
@U-lis U-lis changed the title Feature/claim items Refactor lib9 models Jan 15, 2024
@U-lis U-lis changed the title Refactor lib9 models Refactor lib9c models Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants