-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor lib9c models #216
Conversation
U-lis
commented
Jan 11, 2024
•
edited
Loading
edited
- Create Address model
- Create Currency model
- Create FungibleAssteValue model
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1206314971745052
common/lib9c/models/currency.py
Outdated
return { | ||
"decimalPlaces": b'\x00', | ||
"minters": None, | ||
"ticker": ticker.upper(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mead
같은 케이스를 생각하면 ticker는 밖에서 정하고 보내주는게 좋을것같습니다.
"b3cbca0e64aeb4b5b861047fe1db5a1bec1c241f", | ||
]) | ||
def test_address(addr): | ||
address = Address(addr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ValueError 발생 케이스를 추가하면 좋을것 같습니다.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
실제 claimItems 액션을 생성하는건 이후 pr에서 진행되는건가요? (plainValue가 제대로 셋안되는것처럼 보여서)
네 action 만드는건 이 branch 에서 이어서 commit 쌓을 예정입니다. |