Draft commit for reducing read IOPS in temporary package parts. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKJosh
requested review from
MatthewFoster624,
RyanLuMaye,
mbayerPK and
kirale18
PKJosh
commented
Jan 11, 2023
poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/ZipPackage.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/poi/openxml4j/opc/internal/BufferedEncryptedTempFilePackagePart.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't give any priority to reviewing this. I just wanted this to exist and have you aware of the idea of something I've tested with and confirmed helps us. All we need to do in the Unpacker is call
ZipPackage.setBufferTempFilePackageParts(true)to reap the benefits.