pkp/pkp-lib#10751 EditorialMasthead page issue with eloquent based user group update #10754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @touhidurabir, I believe there are a couple of changes needed in |
touhidurabir
force-pushed
the
i10751_main
branch
from
f8a87be to
9ae0d53
Compare
|
@kaitlinnewson Thanks for pointing it out . I have updated it . |
touhidurabir
force-pushed
the
i10751_main
branch
from
9ae0d53 to
9fd3940
Compare
bozana
reviewed
Jan 6, 2025
bozana
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Hi @touhidurabir, I left a comment i.e. questions regarding getting users, grouped by mastehad roles, and ordered by their family i.e. given name.
…ed on user collector
touhidurabir
force-pushed
the
i10751_main
branch
from
1b6eb5b to
280ec50
Compare
|
@bozana I have updated the PR (check the all PRs list at #10751 (comment)) . Please take a look again and if all tests pass, it should be good to merge . |
|
Also added a commit fixed context settings access issue which fix another regression which cause the context setting section inaccessible . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #10751