Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider new ORCID guidelines for displaying not unauthenticated ORCID iDs #10792

Closed
bozana opened this issue Jan 10, 2025 · 9 comments
Closed

Consider new ORCID guidelines for displaying not unauthenticated ORCID iDs #10792

bozana opened this issue Jan 10, 2025 · 9 comments
Assignees
@taslangraham
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone
3.5.0 LTS

Comments

@bozana
Copy link
Collaborator

bozana commented Jan 10, 2025

The guideline for unauthenticated ORCID iDs seem to be new -- another ORCID icon should be used in that case. Currently we do not display any icon for unauthenticated ORCID iDs, so this needs to be changed.
@bozana bozana added this to the 3.5.0 LTS milestone Jan 10, 2025
@bozana bozana added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Jan 10, 2025
@taslangraham
Copy link
Contributor

@bozana just confirming if this the new guideline you are referring to.

@bozana
Copy link
Collaborator Author

bozana commented Jan 15, 2025

Yes, sorry that I forgot to insert the link to it.
Thanks @taslangraham!

@taslangraham taslangraham self-assigned this Jan 15, 2025
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 17, 2025
@taslangraham
pkp#10792 WIP:update brand guideline
5ea901a
taslangraham added a commit to taslangraham/ui-library that referenced this issue Jan 17, 2025
@taslangraham
pkp/pkp-lib#10792 WIP:update brand guideline
67f04d3
@taslangraham
Copy link
Contributor

taslangraham commented Jan 17, 2025 •
edited
Loading

@ewhanson @bozana There are two public facing pages that I'm unsure about displaying the new icon for users with an unauthenticated ORCiD - the about/editorialMasthead page and on the article page? Do you think it we should display the unauthenticated icon for user's on these pages too?

Article page
Image

editorialMasthead page

Image

@bozana
Copy link
Collaborator Author

bozana commented Jan 19, 2025

Hi @taslangraham, for the masthead: we should only display authenticated ORCID IDs there.
I am not sure about the article view page, I would say we should consider it there, but maybe @Devika008 and @ewhanson could help?

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 20, 2025
@taslangraham
pkp#10792 WIP:update brand guideline
ee94191
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 21, 2025
@taslangraham
pkp#10792 WIP:update brand guideline
fd6e838
@taslangraham taslangraham mentioned this issue Jan 21, 2025
Merged
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 21, 2025
@taslangraham
pkp#10792 Update ORCiD brand guidelines
8a4d04a
taslangraham added a commit to taslangraham/ui-library that referenced this issue Jan 21, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD brand guideline
10f4eec
@taslangraham taslangraham mentioned this issue Jan 21, 2025
Merged
taslangraham added a commit to taslangraham/ui-library that referenced this issue Jan 21, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD brand guideline
3cad2a1
taslangraham added a commit to taslangraham/ojs that referenced this issue Jan 21, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding
16e705f
@taslangraham taslangraham mentioned this issue Jan 21, 2025
Merged
taslangraham added a commit to taslangraham/ops that referenced this issue Jan 21, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD brand guideline
6e83443
@taslangraham taslangraham mentioned this issue Jan 21, 2025
Merged
taslangraham added a commit to taslangraham/omp that referenced this issue Jan 21, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding
0cb7ea6
@taslangraham taslangraham mentioned this issue Jan 21, 2025
Merged
taslangraham added a commit to taslangraham/omp that referenced this issue Jan 21, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding
bab88bf
@taslangraham
Copy link
Contributor

Ready for review @ewhanson

PRs
pkp-lib: #10829
ui-library: pkp/ui-library#490
ojs: pkp/ojs#4614
ops: pkp/ops#849
omp: pkp/omp#1815

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 21, 2025
@taslangraham
pkp#10792 Update ORCiD brand guidelines
efc7e5a
@ewhanson
Copy link
Collaborator

Thanks, @taslangraham! Overall looks good. Just a few questions.

taslangraham added a commit to taslangraham/ui-library that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD brand guideline
3dd7498
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 24, 2025
@taslangraham
pkp#10792 Update ORCiD brand guidelines
b27797f
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 24, 2025
@taslangraham
pkp#10792 Update ORCiD brand guidelines
e28dd00
taslangraham added a commit to taslangraham/ojs that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding
695e913
@taslangraham
Copy link
Contributor

@ewhanson I've addressed your concerns/questions on the PRs. Namely:
pkp-lib: #10829
ops: pkp/ops#849

@ewhanson
Copy link
Collaborator

Thanks, @taslangraham! Looks good.

I think OJS will need a rebase/submodule update, but feel free to merge once that's done.

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 24, 2025
@taslangraham
pkp#10792 Update ORCiD brand guidelines
696128d
taslangraham added a commit to taslangraham/ui-library that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD brand guideline
d660fa8
taslangraham added a commit to taslangraham/ojs that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding
3d39632
taslangraham added a commit to taslangraham/ops that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD brand guideline
6ffa5c4
taslangraham added a commit that referenced this issue Jan 24, 2025
@taslangraham
#10792 Update ORCiD branding (#10829)
3f903cb
taslangraham added a commit to pkp/ui-library that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding (#490)
d9be8e0
taslangraham added a commit to pkp/ojs that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding
d3a9252
taslangraham added a commit to pkp/ops that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding(#849)
2fb33cf 
* pkp/pkp-lib#10792 Update ORCiD brand guideline

* Submodule update
taslangraham added a commit to pkp/omp that referenced this issue Jan 24, 2025
@taslangraham
pkp/pkp-lib#10792 Update ORCiD branding (#1815)
46dfb55 
* pkp/pkp-lib#10792 Update ORCiD branding

* Submodule update
@taslangraham
Copy link
Contributor

All merged! Thanks fro the review @ewhanson

kaitlinnewson added a commit to kaitlinnewson/bootstrap3 that referenced this issue Jan 28, 2025
@kaitlinnewson
pkp/pkp-lib#10792 add unauthenticated orcid handling and use hasVerif…
7859bf8 
…iedOrcid
kaitlinnewson added a commit to kaitlinnewson/classic that referenced this issue Jan 28, 2025
@kaitlinnewson
pkp/pkp-lib#10792 add unauthenticated orcid handling and use hasVerif…
ebe4ed1 
…iedOrcid
kaitlinnewson added a commit to kaitlinnewson/immersion that referenced this issue Jan 28, 2025
@kaitlinnewson
pkp/pkp-lib#10792 add unauthenticated orcid handling and use hasVerif…
164fc7b 
…iedOrcid
kaitlinnewson added a commit to kaitlinnewson/healthSciences that referenced this issue Jan 28, 2025
@kaitlinnewson
pkp/pkp-lib#10792 add unauthenticated orcid handling and use hasVerif…
b87c017 
…iedOrcid
kaitlinnewson added a commit to kaitlinnewson/pragma that referenced this issue Jan 28, 2025
@kaitlinnewson
pkp/pkp-lib#10792 add unauthenticated orcid handling and use hasVerif…
2983a68 
…iedOrcid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taslangraham taslangraham

Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
3 participants
@bozana @ewhanson @taslangraham