Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix I9707_WeblateUILocales, consider locales in arrays #10729

Closed
bozana opened this issue Dec 17, 2024 · 4 comments
Closed

Fix I9707_WeblateUILocales, consider locales in arrays #10729

bozana opened this issue Dec 17, 2024 · 4 comments
Assignees
@bozana
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.5 Internal

Comments

@bozana
Copy link
Collaborator

bozana commented Dec 17, 2024 •
edited
Loading

The migration script I9707_WeblateUILocales, that migrates all locales to Weblate locales, that is introduced here #9707, considers only the columns locale and primary_locale. It should however consider also supported locales context settings, site installed and supported locales, as well as custom block plugin (in plugin_settings).

PRs:
@bozana bozana added this to the 3.5 Internal milestone Dec 17, 2024
@bozana bozana changed the title Fix I9707_WeblateUILocales Fix I9707_WeblateUILocales, consider locales in arrays Dec 17, 2024
@bozana bozana self-assigned this Dec 17, 2024
@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Dec 17, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Dec 18, 2024
@bozana
pkp#10729 fix I9707_WeblateUILocales, consider locales in arrays and …
e6dc25b 
…settings
bozana added a commit to bozana/pkp-lib that referenced this issue Dec 18, 2024
@bozana
pkp#10729 fix I9707_WeblateUILocales, consider locales in arrays and …
63f18cf 
…setting values
bozana added a commit to bozana/ojs that referenced this issue Dec 18, 2024
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
c25bc53 
…ays and setting values
bozana added a commit to bozana/ojs that referenced this issue Dec 18, 2024
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
4a666fb
bozana added a commit to bozana/pkp-lib that referenced this issue Dec 18, 2024
@bozana
pkp#10729 fix I9707_WeblateUILocales, consider locales in arrays and …
e920699 
…setting values
bozana added a commit to bozana/ojs that referenced this issue Dec 18, 2024
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
d2a6e44 
…ays and setting values
bozana added a commit to bozana/ojs that referenced this issue Dec 18, 2024
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
b0d91e5
This was referenced Dec 18, 2024
Merged
Merged
bozana added a commit to bozana/omp that referenced this issue Dec 18, 2024
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
2eafd03 
…ays and setting values
bozana added a commit to bozana/omp that referenced this issue Dec 18, 2024
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
77adbaf
@bozana bozana mentioned this issue Dec 18, 2024
Merged
bozana added a commit to bozana/ops that referenced this issue Dec 18, 2024
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
ee55c9c 
…ays and setting values
bozana added a commit to bozana/ops that referenced this issue Dec 18, 2024
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
65df688
@bozana bozana mentioned this issue Dec 18, 2024
Merged
@bozana
Copy link
Collaborator Author

bozana commented Dec 18, 2024

Hi @jonasraoni, could you please review the PRs above?
Thanks a lot!

@bozana
Copy link
Collaborator Author

bozana commented Jan 3, 2025

Hi @jonasraoni, I just wanted to remind you about this one, in case you have fully forgotten it (also because of the holidays) :-)

p.s. Happy New Year! :-)

@jonasraoni
Copy link
Contributor

jonasraoni commented Jan 13, 2025 •
edited
Loading

Opss, sorry for the delay, I really forgot to review these PRs (or perhaps they are lost in my tabs paradise 👀)

bozana added a commit to bozana/pkp-lib that referenced this issue Jan 18, 2025
@bozana
pkp#10729 fix I9707_WeblateUILocales, consider locales in arrays and …
1b9844f 
…setting values
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 18, 2025
@bozana
pkp#10729 fix I9707_WeblateUILocales, consider locales in arrays and …
510a90e 
…setting values
bozana added a commit to bozana/ojs that referenced this issue Jan 18, 2025
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
cf1c669 
…ays and setting values
bozana added a commit to bozana/ojs that referenced this issue Jan 18, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
829fd7a
@bozana
Copy link
Collaborator Author

bozana commented Jan 18, 2025

Hi @jonasraoni, I think I have considered all comments. Could you please take another look?
Thanks a lot!

bozana added a commit to bozana/omp that referenced this issue Jan 18, 2025
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
3bd7b2b 
…ays and setting values
bozana added a commit to bozana/omp that referenced this issue Jan 18, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
75fdef8
bozana added a commit to bozana/ops that referenced this issue Jan 18, 2025
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
9344e53 
…ays and setting values
bozana added a commit to bozana/ops that referenced this issue Jan 18, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
b2d0c67
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 19, 2025
@bozana
pkp#10729 fix I9707_WeblateUILocales, consider locales in arrays and …
da75f8e 
…setting values
bozana added a commit to bozana/ojs that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
a5d6d9b
bozana added a commit to bozana/omp that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
5d388d9
bozana added a commit to bozana/ops that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
ed8d419
bozana added a commit to bozana/ojs that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
2ce17e6 
…ays and setting values
bozana added a commit to bozana/ojs that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
93832d8
bozana added a commit to bozana/omp that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
0dcb83c 
…ays and setting values
bozana added a commit to bozana/omp that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
bc21d7c
bozana added a commit to bozana/ops that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arr…
a39544f 
…ays and setting values
bozana added a commit to bozana/ops that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
6242569
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 19, 2025
@bozana
pkp#10729 fix I9707_WeblateUILocales, consider locales in arrays and …
f504637 
…setting values
bozana added a commit to bozana/ojs that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
23e46a1
bozana added a commit to bozana/omp that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
d754d87
bozana added a commit to bozana/ops that referenced this issue Jan 19, 2025
@bozana
pkp/pkp-lib#10729 submodule update ##bozana/10729##
cd4ce62
bozana added a commit that referenced this issue Jan 19, 2025
@bozana
Merge pull request #10734 from bozana/10729
adacbdb 
#10729 fix I9707_WeblateUILocales, consider locales in arr…
bozana added a commit to pkp/ojs that referenced this issue Jan 19, 2025
@bozana
Merge pull request #4565 from bozana/10729
fa7f1f9 
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arrays and setting values
bozana added a commit to pkp/omp that referenced this issue Jan 19, 2025
@bozana
Merge pull request #1791 from bozana/10729
2fd9497 
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arrays and setting values
bozana added a commit to pkp/ops that referenced this issue Jan 19, 2025
@bozana
Merge pull request #831 from bozana/10729
b31e76e 
pkp/pkp-lib#10729 fix I9707_WeblateUILocales, consider locales in arrays and setting values
@bozana bozana closed this as completed Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
2 participants
@jonasraoni @bozana