pkp/pkp-lib#9533 Adds decisions constants migration for OPS 3.4.0 #597
Conversation
Signed-off-by: Jhon <jhon@lepidus.com.br> Signed-off-by: Iudi <iudi@lepidus.com.br>
| // \PKP\decision\Decision::REVERT_INITIAL_DECLINE | ||
| [ | ||
| 'stage_id' => [WORKFLOW_STAGE_ID_PRODUCTION], | ||
| 'current_value' => 17, |
There was a problem hiding this comment.
for the \PKP\decision\Decision::REVERT_INITIAL_DECLINE, the current_value should be 18 . the changes can be compared at https://github.com/pkp/pkp-lib/pull/8218/files#diff-62bb1ef0ef526750d90461c6e3f7538f6da0f85260a6575f8b02fe44f3d763aeL38-R45 .
There was a problem hiding this comment.
In OPS 3.3.0, when declining a submission, it generates a decision with INITIAL_DECLINE value. However, when reversing this declining, it creates a decision with REVERT_DECLINE value, instead of REVERT_INITIAL_DECLINE.
Declinings and reversals in 3.3.0:
In OPS 3.4.0, the declining is also the INITIAL_DECLINE, but the reversing is a REVERT_INITIAL_DECLINE (what is more semantically correct).
Declinings and reversals in 3.4.0:
This is the reason why we migrate the value from REVERT_DECLINE (17) in 3.3.0 to REVERT_INITIAL_DECLINE (16) in 3.4.0.
|
Closing in favor of #600 |
This PR is related to #9533