-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn から pnpm に変更 #702
base: main
Are you sure you want to change the base?
yarn から pnpm に変更 #702
Conversation
Visit the preview URL for this PR (updated for commit 491e4a7): https://pixiv-charcoal-web--pr702-naporitan-use-pnpm-0ek36ks1.web.app (expires Thu, 27 Feb 2025 08:14:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
057b227
to
491e4a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ビルド&テスト&storybook動作良さそう。
#701 とコンフリクトするのでどっち先にマージするか決める必要があります。
また、ビルド構成が変わるので、一回betaとかとしてリリースしてみても良さそう
@@ -9,9 +9,12 @@ jobs: | |||
|
|||
steps: | |||
- uses: actions/checkout@v3 | |||
- uses: pnpm/action-setup@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[QUESTION] setup-nodeしているとしてない箇所があると思いますがどういう使い分けですか?
やったこと
yarn から pnpm に変更
strybook の
storybook-dark-mode
のuseDarkMode
を使用すると storybook が壊れたので回避策を使用bundle-size と test-storybook が落ちてる
動作確認環境
pnpm test
pnpm lint
pnpm fmt
pnpm build
pnpm typecheck
pnpm typecheck:config
チェックリスト
不要なチェック項目は消して構いません