-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello image snapshots #461
Conversation
55d18c2
to
6c2438e
Compare
Size Change: 0 B Total Size: 621 kB ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit fdaf7a3): https://pixiv-charcoal-web--pr461-mimo-hello-image-sna-fgj1d0lt.web.app (expires Tue, 19 Mar 2024 05:56:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
d7d441b
to
b536687
Compare
b536687
to
e162257
Compare
6628948
to
e14d644
Compare
e14d644
to
1ef10b3
Compare
1ef10b3
to
1922dc2
Compare
1922dc2
to
eca2f72
Compare
5af5aaf
to
9558b3f
Compare
9558b3f
to
c835154
Compare
93506e2
to
bf87e08
Compare
718ddea
to
49089d3
Compare
9080e52
to
bf2eb1f
Compare
docker/storybook-server/Dockerfile
Outdated
@@ -0,0 +1,16 @@ | |||
# syntax = docker/dockerfile:1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is docker never used for VRT in GitHub Actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remove it.
.github/workflows/test-storybook.yml
Outdated
npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \ | ||
"npx http-server storybook-static --port 6006 --silent" \ | ||
"npx wait-on tcp:127.0.0.1:6006 && yarn test-storybook" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these commands be combined into one script in package.json?
package.json
Outdated
@@ -16,9 +16,10 @@ | |||
"clean": "yarn workspaces foreach -vp run clean", | |||
"test": "jest", | |||
"test:strict": "USE_STRICT=1 jest", | |||
"test-storybook": "test-storybook", | |||
"test-storybook:pull-main": "test-storybook --url https://pixiv.github.io/charcoal --updateSnapshot", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this command never used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
I thought it would be nice to provide it as an option, so I deleted it.
d9ed833
to
44b6aad
Compare
44b6aad
to
99d1545
Compare
99d1545
to
fdaf7a3
Compare
やったこと
動作確認環境
チェックリスト
不要なチェック項目は消して構いません