From 99d154541272d15d70ffe08cf0cb78d4d95600b1 Mon Sep 17 00:00:00 2001 From: mimo Date: Tue, 12 Mar 2024 14:40:32 +0900 Subject: [PATCH] chore: clenup scripts --- .github/workflows/test-storybook.yml | 10 ++-------- package.json | 3 +-- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test-storybook.yml b/.github/workflows/test-storybook.yml index 56e5eaa8b..2f862a39e 100644 --- a/.github/workflows/test-storybook.yml +++ b/.github/workflows/test-storybook.yml @@ -125,16 +125,10 @@ jobs: path: __image_snapshots__/ - name: Serve Storybook and run tests if: steps.label-checking.outputs.result != 'true' - run: | - npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \ - "npx http-server storybook-static --port 6006 --silent" \ - "npx wait-on tcp:127.0.0.1:6006 && yarn test-storybook" + run: yarn test:image-snapshot - name: Serve Storybook and take new image snapshots if: steps.label-checking.outputs.result == 'true' - run: | - npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \ - "npx http-server storybook-static --port 6006 --silent" \ - "npx wait-on tcp:127.0.0.1:6006 && yarn test-storybook --updateSnapshot" + run: yarn test:image-snapshot --updateSnapshot - name: Archive image snapshot diffs uses: actions/upload-artifact@v4 if: failure() && steps.label-checking.outputs.result != 'true' diff --git a/package.json b/package.json index 03e4afee8..b02214fa2 100644 --- a/package.json +++ b/package.json @@ -16,8 +16,7 @@ "clean": "yarn workspaces foreach -vp run clean", "test": "jest", "test:strict": "USE_STRICT=1 jest", - "test:image-snapshot": "concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on tcp:127.0.0.1:6006 && test-storybook\"", - "test:image-snapshot-fetch-main": "test-storybook --url https://pixiv.github.io/charcoal --updateSnapshot", + "test:image-snapshot": "concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on tcp:127.0.0.1:6006 && test-storybook ${*}\"", "typecheck": "yarn workspaces foreach -vp run typecheck", "typecheck:config": "tsc", "lint": "run-p 'lint:*'",