Skip to content

Commit

Permalink
chore: clenup scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
mimokmt committed Mar 12, 2024
1 parent a397d5c commit 99d1545
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
10 changes: 2 additions & 8 deletions .github/workflows/test-storybook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,16 +125,10 @@ jobs:
path: __image_snapshots__/
- name: Serve Storybook and run tests
if: steps.label-checking.outputs.result != 'true'
run: |
npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
"npx http-server storybook-static --port 6006 --silent" \
"npx wait-on tcp:127.0.0.1:6006 && yarn test-storybook"
run: yarn test:image-snapshot
- name: Serve Storybook and take new image snapshots
if: steps.label-checking.outputs.result == 'true'
run: |
npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
"npx http-server storybook-static --port 6006 --silent" \
"npx wait-on tcp:127.0.0.1:6006 && yarn test-storybook --updateSnapshot"
run: yarn test:image-snapshot --updateSnapshot
- name: Archive image snapshot diffs
uses: actions/upload-artifact@v4
if: failure() && steps.label-checking.outputs.result != 'true'
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
"clean": "yarn workspaces foreach -vp run clean",
"test": "jest",
"test:strict": "USE_STRICT=1 jest",
"test:image-snapshot": "concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on tcp:127.0.0.1:6006 && test-storybook\"",
"test:image-snapshot-fetch-main": "test-storybook --url https://pixiv.github.io/charcoal --updateSnapshot",
"test:image-snapshot": "concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on tcp:127.0.0.1:6006 && test-storybook ${*}\"",
"typecheck": "yarn workspaces foreach -vp run typecheck",
"typecheck:config": "tsc",
"lint": "run-p 'lint:*'",
Expand Down

0 comments on commit 99d1545

Please sign in to comment.