Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mechanism to specify maximal duration of tests #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

majirosstefan
Copy link

When the app crashed during testing ( after it was successfully booted/launched), it kept wasting CI resources...

…during testing after it was booted, it kept wasting CI resources)
@jalada
Copy link
Contributor

jalada commented Nov 2, 2021

Great shout @majirosstefan we already have a boot timeout but we should totally have a --run-timeout too!

@jalada jalada added the good first issue Good for newcomers label Nov 2, 2021
@majirosstefan
Copy link
Author

Well, I did not expect such a fast reply :)
Thanks, I actually wrote a blog post about Cavy, and I promised in the comments on Twitter that I will create a pull request.. soo, here it is.

Feel free to edit & rename things :)

@jalada
Copy link
Contributor

jalada commented Nov 2, 2021

Feel free to edit & rename things :)

I didn't spot this was a PR, I thought it was an issue 😂 thanks for this! We're fully stacked at Pixie Labs on project stuff at the moment, but hopefully towards the end of the year when things quieten down, we'll get this in (at the latest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants