GAS V8 Runtime updates #15
Conversation
|
Can we get this merged? |
| function isa_(obj, class) { | ||
| return typeof obj == 'object' && typeof obj.constructor == 'undefined' && obj.toString() == class; | ||
| function isa_(obj, className) { | ||
| return typeof obj == 'object' && (typeof obj.constructor == 'undefined' || typeof obj.constructor == 'function') && obj.toString() == className; |
There was a problem hiding this comment.
V8 is now supporting class and constructors. I've tested this update and it works for me
|
|
||
| function gettz_() { | ||
| var d = new Date(); // now, or the specific date in question | ||
| var s = d.toLocaleString("en", {timeZoneName: "short"}).split(' ').pop(); |
There was a problem hiding this comment.
This might fix part of the issue. In my case (US Mountain), the value is still not supported. The safest way is to get the timezone value from App script itself. I'll send a pull request for the code I have been using.
| @@ -538,3 +538,4 @@ function md5_(str) { | |||
| chr = (chr < 0 ? chr + 256 : chr).toString(16); | |||
| return str + (chr.length==1?'0':'') + chr; | |||
| },''); | |||
| } | |||
|
Hello, I confirm the current code doesn't work for me, but with modifications from @lex3001 it now works ! Can you please merge this fix in your repo which is the master please? Thank you ! |
|
@emmanueljarri I gave up on these guys a long time ago, seems like this project is abandoned sadly. You are welcome to use my updated library with ID: 1CdCFwL5USI7KRfuVfoOWXJUCo4kGTL05fRwDPmpJVzETix09Nuy_v8bK |
I made two changes so that this works with the new Google Apps Script V8 Runtime. It should still work with the old version too, but I am not 100% sure about that.