Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debug output #518

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Improve debug output #518

merged 2 commits into from
Jan 17, 2025

Conversation

davewalter
Copy link
Contributor

  • Add the remote version to the download log message
  • Remove the file info log line from the Artifactory release source

@davewalter davewalter requested a review from drich10 January 14, 2025 15:49
drich10
drich10 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@drich10 drich10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a useful additive improvement.

The other option I would have considered is listing out the remote url(s) based on the source as well or instead?

internal/component/artifactory_release_source.go Show resolved Hide resolved
@davewalter
Copy link
Contributor Author

The other option I would have considered is listing out the remote url(s) based on the source as well or instead?

I could see that being helpful for debugging, but maybe too noisy for verification that it is doing what you expect?

@davewalter davewalter merged commit 109f8d3 into main Jan 17, 2025
3 checks passed
@davewalter davewalter deleted the improve-debug-output branch January 17, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drich10 drich10 drich10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davewalter @drich10