fix coveity defects

pit-ray · Jan 14, 2024 · b3e512b · b3e512b
1 parent 2ee00d3
commit b3e512b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/bind/bindinglist.cpp b/src/bind/bindinglist.cpp
@@ -319,5 +319,10 @@ namespace vind
         BindedFunc::SPtr search_func(const std::string& name) {
             return search_func(BindedFunc::name_to_id(util::A2a(name))) ;
         }
+
+        BindedFunc::SPtr search_func(std::string&& name) {
+            return search_func(
+                BindedFunc::name_to_id(util::A2a(std::move(name)))) ;
+        }
     }
 }
diff --git a/src/bind/bindinglist.hpp b/src/bind/bindinglist.hpp
@@ -13,10 +13,11 @@ namespace vind
 
         BindedFunc::SPtr search_func(std::size_t id) ;
         BindedFunc::SPtr search_func(const std::string& name) ;
+        BindedFunc::SPtr search_func(std::string&& name) ;
 
         template <typename T>
         inline bool check_if_func(T&& arg) {
-            return search_func(arg) != nullptr ;
+            return search_func(std::forward<T>(arg)) != nullptr ;
         }
     }
 }

diff --git a/src/opt/optionlist.hpp b/src/opt/optionlist.hpp
@@ -37,7 +37,7 @@ namespace vind
 
         template <typename T>
         inline bool check_if_option(T&& name) {
-            return search_option(name) != nullptr ;
+            return search_option(std::forward<T>(name)).get() != nullptr ;
         }
     }
 }