Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 使用更靠谱的方法从json提取数据 #193

Merged
merged 3 commits into from
Dec 24, 2023

Conversation

14790897
Copy link
Contributor

@14790897 14790897 commented Dec 19, 2023

目前还未去掉头部的两个system信息

closes #190

@14790897
Copy link
Contributor Author

😎

@14790897
Copy link
Contributor Author

这个提交流程好专业,学习了

@pionxzh
Copy link
Owner

pionxzh commented Dec 19, 2023

我看了下大致理解你的思路,findBottomMostNode 事实上可以直接用 ApiConversation.current_node 来找,然后由下至上的建构虽然简单,但最重要的是怎样定位 "正确的" 节点,因为 "复制" 的预期应该是将用户当前所看见的结果给复制下来,而不是只选择最新的节点就好

理论上一律使用最新节点可能也符合90%的使用场景,所以我觉得也许可以如果 mapping 过程发现任何应该要有选择而 dom 上却没正确找到的,fallback 回使用这个方法

@14790897
Copy link
Contributor Author

No no我的正确率是100%

@pionxzh
Copy link
Owner

pionxzh commented Dec 21, 2023

我晚上看看

@14790897
Copy link
Contributor Author

如果是原来的代码,因为没有前端,export all是不能正常工作的

@14790897
Copy link
Contributor Author

我之前有几个对话因此丢过数据,我相信这个困扰很多人都有,估计很多客户就直接流失了

Copy link
Owner

@pionxzh pionxzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不管 dom 了,这玩意复杂状况下总是有 edge case,用这个方法吧

@pionxzh pionxzh merged commit dc157f7 into pionxzh:master Dec 24, 2023
1 check passed
@14790897
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export is using the wrong conversation choice
2 participants