Goods Trader - Glitch in prices

[zonkmachine]

There seem to be some inconsistency in how the Goods Trader works compared to the Commodity Market.

Observed behaviour

1 - In the commodity market, if you buy a unit of something and then immediately sell it, you will end up loosing money. If you do the same at the Goods Traders, you will end up with what you started with.
2 - The price offered is not the one in the price table but the sum of the buy and sell prices, before rounding off. This explains 1 above.
3 - According to this comment,

pioneer/data/modules/GoodsTrader/GoodsTrader.lua

Lines 159 to 160 in ddb008d

	-- going rate on the black market will be twice normal
	ad.price[comm] = ad.station:GetCommodityPrice(comm) * 2

the prices at the Goods Trader is simply twice that of the Commodity Market. This doesn't seem to hold true in reality. See 2 above.

Expected behaviour

The prices between buy and sell should differ like in the commodity market.
The price offered should be the one in the price table and not some multiple of it.

Steps to reproduce

1

• Note your cash ammount.
• Buy one piece of one commodity at a Goods Trader. See the cash drop.
• Immediately sell the same it and watch the

2

• Note the price to buy and sell one object
• Add one to buy and note the suggested price
• It will be the sum or the buy and sell

My pioneer version (and OS):

Pioneer-20250203