expression: builtin functions variance,var_pop,var_samp,std,stddev,stddev_pop,stddev_samp with DISTINCT should raise a syntax error
#21382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we fix this issue in the parse phase? |
@XuHuaiyu Yes, it's better! Shall we open a new issue in parser? |
hidehalo
changed the title
DISTINCT should raise a syntax error
|
I think it should close for now, if it is necessary for related issue, we just let it re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19499
Problem Summary:
What is changed and how it works?
Proposal
we should fix it in parser.
parser's PR ref pingcap/parser#1123
What's Changed:
fixed in parser
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note
DISTINCTshould raise a syntax error