Improve markdown snippets #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wJoenn
reviewed
Dec 1, 2023
wJoenn
approved these changes
Dec 1, 2023
|
C'est beau ! |
pil0u
approved these changes
Dec 1, 2023
| @@ -29,7 +29,21 @@ | |||
| } | |||
|
|
|||
| .code-highlight pre { | |||
| @apply px-1 border border-aoc-gray-darker rounded; | |||
| @apply px-6 py-4 border border-aoc-gray-darker rounded; | |||
| @apply bg-dark !important; | |||
There was a problem hiding this comment.
Pour l'instant oui. On a du style appliqué directement sur l'élément par Commonmarker, c'est la seule façon de l'override.
There was a problem hiding this comment.
Je l'ai constaté en faisant une passe, bien vu !
| @apply px-6 py-4 border border-aoc-gray-darker rounded; | ||
| @apply bg-dark !important; | ||
|
|
||
| position: relative; |
There was a problem hiding this comment.
Tu peux utiliser @apply relative avec Tailwind 👍
Comment on lines
+40
to
+44
| text-transform: capitalize; | ||
|
|
||
| position: absolute; | ||
| top: -1px; | ||
| right: -1px; |
There was a problem hiding this comment.
@apply absolute -top-px -right-px capitalize
| top: -1px; | ||
| right: -1px; | ||
|
|
||
| @apply px-2 border border-aoc-gray-darker text-aoc-gray font-medium text-sm rounded-tr; |
There was a problem hiding this comment.
On n'a pas de font-medium sur le projet, seulement font-light et font-semibold. Techniquement si tu utilises autre chose ça fallback au plus proche, mais c'est pas "correct".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes and context
Follow-up de #342. Inclut:
~~~(qui sont autorisés par la spec)rubyaprès les backticks, on colore quand même basé sur le language du snippet)Sanity checks