feat(snippets): reactions #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AH |
pil0u
reviewed
Nov 30, 2023
pil0u
approved these changes
Nov 30, 2023
Aquaj
approved these changes
Dec 1, 2023
| }.freeze | ||
|
|
||
| def initialize(snippet:, reaction_type:, user:) | ||
| @user = user |
There was a problem hiding this comment.
Ça serait un bon cas d'utilisation pour Current.user afin de skipper le passage de @user à travers plusieurs couches nestées (View -> Component -> View -> ici) juste pour arriver ici.
(Pas bloquant, je dis juste pour garder en tête des refactos possibles)
|
Ready to merge quand tu te le sens, @pil0u. |
Aquaj
reviewed
Dec 1, 2023
Comment on lines
+6
to
+22
| <% if @reactions.pluck(:user_id).include?(@user.id) %> | ||
| <%= button_to "#{EMOTES[@reaction_type][:emote]} #{@reactions.count}", | ||
| delete_reaction_path(id: @reactions.find_by(user: @user).id), | ||
| method: :delete, | ||
| class: "border border-aoc-green cursor-pointer duration-300 px-1.5 rounded-full transition-colors hover:bg-aoc-gray-darker" %> | ||
| <% elsif @snippet.reactions.pluck(:user_id).include?(@user.id) %> | ||
| <%= button_to "#{EMOTES[@reaction_type][:emote]} #{@reactions.count}", | ||
| update_reaction_path(id: @snippet.reactions.find_by(user: @user).id), | ||
| params: { reaction: { reaction_type: @reaction_type } }, | ||
| method: :patch, | ||
| class: "border border-aoc-gray-dark cursor-pointer duration-300 px-1.5 rounded-full transition-colors hover:bg-aoc-gray-darker" %> | ||
| <% else %> | ||
| <%= button_to "#{EMOTES[@reaction_type][:emote]} #{@reactions.count}", | ||
| reactions_path(@snippet.id), | ||
| params: { reaction: { reaction_type: @reaction_type } }, | ||
| class: "border border-aoc-gray-dark px-1.5 duration-300 rounded-full transition-colors #{'cursor-pointer hover:bg-aoc-gray-darker' unless @snippet.reactions.pluck(:user_id).include?(@user.id)}" %> | ||
| <% end %> |
There was a problem hiding this comment.
Simplifiable avec un chouïa de dynamisme et en passant par 1 seule action de controller au lieu de trois (que ça soit le back qui gère cette logique).
Mais pas bloquant, on pourra refaire plus tard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes and context
closes #269
This is a MVP for the snipppets' reaction system.
Eventually I'd like to add a transition to the tooltip so that it fades in from the bottom but it's gonna need JavaScript.
I also want to be able to update reactions without reloading the page, or at least without scrolling back at the top.
It was might doable with Turbo ? I haven't really used it yet, otherwise it should easily be doable with JavaScript too.
Le.Wagon.x.Advent.of.Code.-.Brave.2023-11-30.20-04-11.mp4
I don't like the fact that one of the
Snippets::ReactionComponent::initializeattributes is calledemoteinstead ofcontentbut apparently the latter is a reserved keyword so I had to change it.The reason I went with
contentis because that's what Github does with their API.Sanity checks