fix(users): remove blank params from user form #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes and context
The favourite language input in the user form is as follow
If a user has no language then
@user.favourite_language
isnil
and when a form input isnil
Rails converts it to an empty string.This means that as long as a user hasn't selected a favourite language, any update he tries to make on his user model will fail because the front sends
{ favourite_language: "" }
which does not pass the validationThis PR fixes this by appending
#compact_blank
to theparams.require().permit
in theUsersController
which removes blank paramsSanity checks