Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped the menus organisation + misc improvements & fixes #349

Merged
merged 9 commits into from
Nov 22, 2023
Merged

Conversation

pil0u
Copy link
Owner

@pil0u pil0u commented Nov 21, 2023

Summary of changes and context

Closes #319.

  • Added Louis in the footer, slightly revamped
  • Exchanged FAQ (footer -> header) with The Wall (header -> footer)
  • Changed Settings tab from icon to full letters
  • Added Admin tab (for admins)
  • Fixed the text in the alert for the Ladder of Insanity with dynamic date
  • Fixed the forms in the admin page
  • Removed legacy text in the participation page
  • Changed the Slack link in the setup from the Slack channel to a dedicated Slack thread

Sanity checks

  • Linters pass
  • Tests pass
  • Related GitHub issues are linked in the description

@pil0u pil0u requested review from wJoenn and Aquaj and removed request for wJoenn November 21, 2023 22:24
app/components/footer/copyright_component.html.erb Outdated Show resolved Hide resolved
app/components/user_form_component.rb Outdated Show resolved Hide resolved
Comment on lines -4 to -7
<p>
The campus which brings the most sign ups - <em>in proportion to their size</em> - by November 30th will be allowed to
customise their name on the platform (custom <span class="text-[#d946ef]">colour</span>, custom 𝑛𝑎𝑚𝑒).
</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ? Plus d'option de customisation pour le batch le plus présent ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas pour l'instant, peut-être que je remettrai la semaine pro. La page n'est pas "publique", au sens où on ne le partage nulle part, c'est plus un outil pour Aurélie et Morgan (community Le Wagon)

@pil0u pil0u merged commit 92acd0b into main Nov 22, 2023
5 checks passed
@pil0u pil0u deleted the misc/menus branch November 22, 2023 19:56
@pil0u pil0u restored the misc/menus branch November 22, 2023 20:43
@pil0u pil0u deleted the misc/menus branch November 22, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajuster la barre de menu
3 participants