Improve 2 achievements to rely on file #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pil0u
changed the title
wJoenn
reviewed
Nov 21, 2023
|
@wJoenn Là c'est plus pour aligner ce type de gestion un peu legacy. Y a sûrement "mieux", mais là ça fait le taf. Si faut refaire un truc ce sera pas dur. |
wJoenn
approved these changes
Nov 21, 2023
|
Bien vu, le truc c'est que pour les gens de 2020 je n'ai que l'aoc_id ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes and context
Transform some ID-based achievements to be linked to a static file.
Removed the users from the 2022 Riddle achievement.
TODO on release: remove the Riddle achievement to people who wrongly unlocked it.
Sanity checks
I ran both achievements locally.