Make scenario calls explicit in mrdrivers functions #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johanneskoch94
commented
Feb 5, 2025
johanneskoch94
commented
- Drop plyr dependency
- Replace calcGDPPop with calcGDPpc from mrdrivers (fixes remove calcGDPPop #34)
- Make scenario calls explicit in mrdrivers functions and refactor in preparation of dropping the gdp_ and pop_ prefixes in mrdrivers scenario names.
- Refactor usd2eur to not use GDPuc internal datasource
Also refactor in preparation of dropping the gdp_ and pop_ prefixes in mrdrivers scenario names.
|
Cool, thanks @johanneskoch94! Could you also drop the accepted note here? |
|
Closes #34 |
robinhasse
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.