Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit the correct value to decline a call. #456

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Emit the correct value to decline a call. #456

merged 1 commit into from
Jan 19, 2025

Conversation

piggz
Copy link
Owner

@piggz piggz commented Jan 17, 2025

Services should emit a service event, which a device will udnerstand, and re-trigger as an AbstractDevice event.

Fixes #448
Fixes #423

Services should emit a service event, which a device will udnerstand,
and re-trigger as an AbstractDevice event.

Fixes #448
Fixes #423
@piggz
Copy link
Owner Author

piggz commented Jan 17, 2025

@jmlich Could you test this... my GTR2 works differently wrt declining calls.

@jmlich
Copy link
Contributor

jmlich commented Jan 19, 2025

I am sorry for noise. It seems to be fixed. I used wrong instance previously )-;.
I can confirm that #448 is fixed. I am not sure about #423, but according to description it sound like the same issue.

@piggz
Copy link
Owner Author

piggz commented Jan 19, 2025

Haha, thats a relief, as i was struggling to figure out what else it could be!

@piggz piggz merged commit 0ac1385 into master Jan 19, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants