Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[huami] Avoid repeated initialization #442

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Dec 27, 2024

Fixes: #375

I am not sure if this is right solution to the issue. However, I am able to connect to Amazfit NEO with this fix.

I was trying to improve debug messages to be able to find source of issue.

@jmlich jmlich marked this pull request as draft December 27, 2024 08:36
@jmlich jmlich force-pushed the huami-avoid-repeated-initialize branch from 40e189a to f1bfa9d Compare December 28, 2024 08:13
@jmlich jmlich marked this pull request as ready for review December 28, 2024 08:34
@jmlich jmlich changed the title Avoid repeated initialization [huami] Avoid repeated initialization Dec 29, 2024
@piggz
Copy link
Owner

piggz commented Jan 10, 2025

What is the actual fix here? Dont initialize until after 60 seconds? There are quite a few debug changes that could be removed to make the commit simpler

@jmlich jmlich force-pushed the huami-avoid-repeated-initialize branch 2 times, most recently from 7c5b965 to 535d71c Compare January 10, 2025 17:40
@jmlich
Copy link
Contributor Author

jmlich commented Jan 10, 2025

The debug changes were moved to separate pull request.

@jmlich jmlich force-pushed the huami-avoid-repeated-initialize branch from 535d71c to 0c6c7b4 Compare January 14, 2025 07:50
@piggz
Copy link
Owner

piggz commented Jan 15, 2025

Have tested and confirmed im still able to connect ok to my GTR2, so should be ok to merge.

@piggz piggz merged commit e1443cf into piggz:master Jan 15, 2025
7 checks passed
@jmlich jmlich deleted the huami-avoid-repeated-initialize branch January 18, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazfit NEO pairing
2 participants