Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations to huami items #441

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Dec 27, 2024

I have noticed that some items are not translated:

screenshot20241227_093249365

@jmlich
Copy link
Contributor Author

jmlich commented Dec 29, 2024

I have added all strings from mibandservice.cpp. I am not sure if qml with "const" variable in javascript will work on SailfishOS

@jmlich
Copy link
Contributor Author

jmlich commented Jan 4, 2025

I have check this with SailfishOS and it works as expected

@piggz piggz merged commit cb8f04c into piggz:master Jan 10, 2025
4 checks passed
@jmlich jmlich deleted the huami-items-translations branch January 10, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants