onUnitNew is triggered with every property check. #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piggz
reviewed
Jan 13, 2025
ui/qml/harbour-amazfish.qml
Outdated
| @@ -147,7 +137,8 @@ ApplicationWindowPL | |||
| signal unitNew(string name) | |||
| onUnitNew: { | |||
There was a problem hiding this comment.
Should we just remove this entire block then?
There was a problem hiding this comment.
You are right, looks much better when whole block is removed.
I added just comment because the checking onUnitNew seems to be reasonable, but leads to unexpected infinite loop.
jmlich
force-pushed
the
systemd-unit-recursion
branch
from
9e41761 to
cf0d872
Compare
If the systemd unit doesn't exist, the call systemdServiceIface.getProperty creates a temporary systemd unit, which triggers onUnitNew. This results in a loop that causes the issue. Fixes piggz#439
jmlich
force-pushed
the
systemd-unit-recursion
branch
from
cf0d872 to
0297d86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the systemd unit doesn't exist, the call systemdServiceIface.getProperty creates a temporary systemd unit, which triggers onUnitNew. This results in a loop that causes the issue.
Fixes #439