add blank default option

picklejason · Dec 18, 2022 · df1df58 · df1df58
1 parent c86ec0a
commit df1df58
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -41,13 +41,8 @@ app.get("/", async (req, res) => {
 
 app.get("/create", async (req, res) => {
   try {
-    pick = `<select name=pokemons id=pokemons required>`;
     pokemons = await getAllPokemons();
-    pokemons.results.forEach((pokemon) => {
-      pick += `<option value="${pokemon.name}">${pokemon.name}</option>`;
-    });
-    pick += `</select>`;
-    res.render("create", { pick: pick });
+    res.render("create", { pokemons });
   } catch (err) {
     console.error(err);
   }

diff --git a/views/create.ejs b/views/create.ejs
@@ -27,7 +27,14 @@
         />
         <label for="pokemon"><strong>Pick your Pokémons</strong></label>
         <br />
-        <%- pick %> <%- pick %> <%- pick %> <%- pick %> <%- pick %> <%- pick %>
+        <% for (let i = 0; i < 6; i++) { %>
+        <select name="pokemons" id="pokemons" required>
+          <option value="" disabled selected>Select a Pokémon</option>
+          <% pokemons.results.forEach((pokemon) => { %>
+          <option value="<%= pokemon.name %>"><%= pokemon.name %></option>
+          <% }); %>
+        </select>
+        <% } %>
         <br />
         <input class="select-text" type="submit" />
       </form>