Skip to content

Commit c3e1097

Browse files
carusogabrielpetk
authored andcommitted
Fix QA Pulls Tool merge instructions
Ignore shared/ folder Add step to ensure to checkout the master branch
1 parent e80874c commit c3e1097

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ reports/db/*.sqlite
22
reports/db/*.cache
33
pftt-reports/*
44
pulls/config.php
5+
shared/

pulls/index.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,13 @@
8484
</script>
8585
<script id="pullInstructionTemplate" type="text/x-jquery-tmpl">
8686
<pre>
87-
$ git fetch git://github.com/php/{{=repo}} pull/{{=number}}/head:pull-request/{{=number}}
88-
$ git log -p pull-request/{{=number}} # REVIEW IT
89-
$ git merge pull-request/{{=number}} # Merge it, add a GOOD commit message
90-
$ make test # you better not forget that
91-
$ git push origin master # everything okay? good, let's push it
87+
$ git checkout master
88+
$ wget https://github.com/php/{{=repo}}/pull/{{=number}}.patch # Download it
89+
$ git am -3 {{=number}}.patch # Merge it with a GOOD commit message
90+
$ make test # you better not forget that
91+
$ git push origin master # everything okay? good, let's push it
9292
</pre>
93+
<p>For a full detailed steps in how to merge into lower branches, check <a href="https://wiki.php.net/vcs/gitworkflow#reviewing_and_closing_pull_requests">our Git Workflow.</a></p>
9394
</script>
9495
<script id="labelsDialogTemplate" type="text/x-jquery-tmpl">
9596
<dd></dd>
@@ -167,4 +168,3 @@
167168
);
168169

169170
common_footer($JS);
170-

0 commit comments

Comments
 (0)