Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Turn PHPT tests into PHPUnit test cases #943

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Enhancement: Turn PHPT tests into PHPUnit test cases #943

merged 1 commit into from
Feb 13, 2024

Conversation

localheinz
Copy link
Contributor

This pull request

  • turns PHPT tests into PHPUnit test cases

Follows #605.

@localheinz localheinz marked this pull request as draft February 13, 2024 12:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

🚀 Commit 9705aae Deployed on https://web-php-pr-943.preview.thephp.foundation

@localheinz localheinz marked this pull request as ready for review February 13, 2024 12:30
@localheinz localheinz force-pushed the feature/unit branch 2 times, most recently from 05b6ea0 to 66dfe86 Compare February 13, 2024 12:31
saundefined
saundefined approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined saundefined merged commit 33dd2a8 into php:master Feb 13, 2024
3 checks passed
@localheinz localheinz deleted the feature/unit branch February 13, 2024 13:25
@localheinz
Copy link
Contributor Author

Thank you, @saundefined!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saundefined saundefined saundefined approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @saundefined