Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme-base.css Add an padding to show the cursor at the beginning of … #1224

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

mmalferov
Copy link
Member

…the line in edit mode

Copy link
Contributor

github-actions bot commented Feb 7, 2025

🚀 Preview for commit a56d798 can be found at https://web-php-pr-1224.preview.thephp.foundation

Copy link
Contributor

github-actions bot commented Feb 7, 2025

🚀 Regression report for commit a56d798 is at https://web-php-regression-report-pr-1224.preview.thephp.foundation

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Might need to update the screenshots to fix the test.

image

@saundefined
Copy link
Member

Or maybe use a more specific selector, e.g. .example-contents .phpcode code?

I guess there is no necessary padding 🤔
https://web-php-pr-1224.preview.thephp.foundation/releases/8.4/en.php

only the child element `code` needs to be `padding` and it already has an `overflow-x`
Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@saundefined saundefined merged commit ae77e8b into php:master Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants