Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use web shared #523

Closed
Aaron-Junker opened this issue Jun 10, 2022 · 3 comments
Closed

Use web shared #523

Aaron-Junker opened this issue Jun 10, 2022 · 3 comments

Comments

@Aaron-Junker
Copy link
Contributor

PHP.net uses different files for header and footer then web-shared. This is not really optimal, because when something gets updated here it won't get updated on other pages.
@Aaron-Junker Aaron-Junker mentioned this issue Jul 6, 2022
Closed
@derickr
Copy link
Member

derickr commented Nov 29, 2023

This is fixed in php/web-shared@b6ed0a9, not?

@github-actions GitHub Actions
Copy link
Contributor

No feedback was provided. The issue is being suspended because we assume that you are no longer experiencing the problem. If this is not the case and you are able to provide the information that was requested earlier, please do so. Thank you.

@Aaron-Junker
Copy link
Contributor Author

@derickr I'm sorry for the late response. No this is not fixed. What I wanted is to include web shared here as a submodule like in the other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@derickr @saundefined @Aaron-Junker