Fix infinite recursion on deprecated attribute evaluation

[iluuu1994]

Fixes GH-17711

Discovered in GH-16952, where the issue is more obvious to reproduce. Optimally, this could have been moved into zend_deprecated_class_constant() to avoid duplication, but that's not possible because it marks the c as const.

[TimWolla]

The fix makes sense to me and is consistent with the existing MARK_CONSTANT_VISITED() mechanism that is used for self-referencing constants.

All tests (no opcache, opcache, JIT) pass for me locally with ASAN, so I can't comment on the CI failures.

[iluuu1994]

The failures are caused by modification of shm... I'll need to switch some things around but was too tired yesterday.

[iluuu1994]

I think it should be fine now. We only need to add recursion protection when the constant value is a constant AST. If it isn't, we won't attempt to evaluate it again. Recursive errors through set_error_handler are explicitly avoided by removing the error handler before triggering the error.

[TimWolla]

Still LGTM, no strong opinion on my suggestion. You're the expert.