ext/pdo: Default Fetch mode handling refactoring. #17694
Draft
+156
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects the value of the fetch mode flags
We don't need to reserve 32 bits when they fit in 9
Girgias
force-pushed
the
pdo-set-default-fetch-mode-refacto
branch
2 times, most recently
from
cc79563 to
a8d21f0
Compare
This is possible as these fetch modes can now only properly be set
This is now possible as we properly verify the fetch mode. This also saves 8 bytes on x64
Girgias
force-pushed
the
pdo-set-default-fetch-mode-refacto
branch
from
a8d21f0 to
5a7ae0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.