Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpdbg: remove dead code and sillyness #13322

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

kaja47
Copy link
Contributor

@kaja47 kaja47 commented Feb 4, 2024

Some struct fields we just written to and never read. Remove them.
Some arguments passed to macros which discards name have rather inventive and confusing names. Change them to NULL.

@kaja47 kaja47 changed the title remove dead code and sillyness phpdbg: remove dead code and sillyness Feb 4, 2024
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@nielsdos nielsdos merged commit 47b05de into php:master Feb 4, 2024
9 of 10 checks passed
@bwoebi
Copy link
Member

bwoebi commented Feb 5, 2024

I ... am a bit sad that my silliness was removed here :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants