Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4: CSV related changes and deprecations の翻訳 #250

Merged
merged 5 commits into from
Jan 19, 2025

Conversation

siwa32
Copy link
Contributor

@siwa32 siwa32 commented Jan 13, 2025

refs #150

php/doc-en#4093 を取り込みました。

また、上記後に変更されてマージされている以下に関しても取り込んでいます。

reference/filesystem/functions/fgetcsv.xml

reference/filesystem/functions/fputcsv.xml

reference/spl/splfileobject/fgetcsv.xml

reference/spl/splfileobject/setcsvcontrol.xml

reference/strings/functions/str-getcsv.xml

siwa32 and others added 5 commits January 13, 2025 22:44
php/doc-en#4093

以下も合わせて取り込む

reference/spl/splfileobject/setcsvcontrol.xml
- [skip-revcheck] Fill xi:fallback to avoid 'variablelist incomplete' in some translations
  - php/doc-en#4128
- Update setcsvcontrol.xml Fix typo
  - php/doc-en#4379

reference/spl/splfileobject/fgetcsv.xml
- Update fgetcsv.xml Remove the duplicate sentence
  - php/doc-en#4111
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

関連箇所をまとめて頂いたおかげでレビューがとてもやりやすかったのと、語句や表現の統一感が出て非常に良かったです。

@KentarouTakeda KentarouTakeda merged commit 3690cd3 into php:master Jan 19, 2025
2 checks passed
@siwa32 siwa32 deleted the doc-en/4093_csv-changes branch January 19, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants