[PHP 8.4] PDOサブクラス・新メソッド #205
Merged
+3,794
−1,287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KentarouTakeda
force-pushed
the
php84-pdo-subclasses
branch
3 times, most recently
from
06526c8 to
8bcf794
Compare
KentarouTakeda
added
the
review wanted
|
@SakiTakamachi |
KentarouTakeda
force-pushed
the
php84-pdo-subclasses
branch
from
8bcf794 to
d707705
Compare
zonuexe
reviewed
Dec 9, 2024
reference/pdo_mysql/pdo-mysql.xml
Outdated
| </simpara> | ||
| </listitem> | ||
| <listitem> | ||
| <simpara> | ||
| Two-dashes, C-style comments, and Hash-comments. | ||
| 2 つのハイフン、C スタイルのコメント、<literal>#</literal> によるコメント |
There was a problem hiding this comment.
この文脈では
-- comment/* comment */# comment
の3種類の形式のコメントのことなので、「〜コメント」は3つそれぞれに付けるか、最後のひとつにまとめた方がいいかもしれません。
「Cスタイル」は日本語では「C言語形式」のようにも置き換えられるかもしれません。
There was a problem hiding this comment.
ありがとうございます！確かに読みやすくなりますね。
465683b で修正しました。同じコミットで、ほぼ同じ文章で「新機能」も訳していたのでそちらへもバックポートしています。
KentarouTakeda
force-pushed
the
php84-pdo-subclasses
branch
from
d707705 to
8e64a12
Compare
zonuexe
reviewed
Dec 9, 2024
| @@ -15,8 +15,8 @@ | |||
| <void/> | |||
| </methodsynopsis> | |||
| <simpara> | |||
| Returns the Firebird API version as defined by the C constant | |||
| <constant>FB_API_VER</constant> in <filename class="headerfile">ibase.h</filename>. | |||
| <filename class="headerfile">ibase.h</filename> 内で C 定数 <constant>FB_API_VER</constant> として定義されている | |||
There was a problem hiding this comment.
こちらもibase.hの定数のことなので、「ibase.h 内でC言語での定数FB_API_VERとして定義されている…」のような文章の方がわかりやすいかもしれません。
There was a problem hiding this comment.
ありがとうございます！ 「C 言語の定数」としました: e9f41b5
他に無いか、プルリクエストを C という文字列で検索しました。
既に翻訳済だった C API を除きすべて C 言語 となりました。
KentarouTakeda
force-pushed
the
php84-pdo-subclasses
branch
from
e9f41b5 to
1044fa7
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
翻訳対象:
補足作業:
[PHP 8.4] PDOサブクラス・新メソッド #205 (review)