Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] DBA resource to Object conversions #185

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

Ippey
Copy link
Contributor

@Ippey Ippey commented Nov 23, 2024

php/doc-en#3914 の変更を反映しました。

一部、翻訳されていたところがあり、未翻訳部分を追加しています。

@KentarouTakeda KentarouTakeda added the review wanted Review wanted. Please feel free to comment; anyone is welcome! label Nov 23, 2024
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

新たに追加されたページのリンク元が見つからなかったので探したところ、原文の元プルリクエストに関連する変更で、どのプルリクエストにも所属しない直コミットを見つけました。レビューのついでにそちらの翻訳コミットも一緒に入れさせてください!

@KentarouTakeda KentarouTakeda merged commit b4a510b into php:master Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review wanted Review wanted. Please feel free to comment; anyone is welcome!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants