.editorconfigと.gitattributesを英語版と同様に設定
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KentarouTakeda
force-pushed
the
add-attribute-files
branch
from
c7ea961 to
c3504bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.editorconfigと.gitattributesを英語版と同様に設定。ファイル内容は全く同じ。既に各ファイル末尾のmodelineでは、タブ幅を初めとするテキストフォーマットが指定されている。
「インデントサイズ = 1」など
php/doc-*固有の設定が多いが、対応エディタが少ないため強制力に乏しい。php/doc-en では同様の指定が
.editorconfigにも設定されているが doc-ja には無い。そのため、指定されたタブ幅と異なるファイルがcommitされるなど不統一を招いている。
EditorConfigにも同様の指定を行うことでそれらの事故を防ぐ。
同時に
.gitattributesも同じ内容を指定。