Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_onceの説明の修正 #128

Merged
merged 1 commit into from
Oct 26, 2024
Merged

include_onceの説明の修正 #128

merged 1 commit into from
Oct 26, 2024

Conversation

takaram
Copy link
Contributor

@takaram takaram commented Sep 26, 2024

php/doc-en#3790 を日本語版に反映しています。

また、ついでにはなりますが、原文と比較して日本語訳がやや異なっている部分を修正しています。

  • 原文の"include_once returns true."の部分は前の文から続いており、「既に読み込まれている場合」の説明の一部であるはず
  • 「重要な違い」というニュアンスは原文にはなさそう

Copy link
Contributor

@youkidearitai youkidearitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
確かに include は式なのでLGTMです!

一応 @mumumu さんも確認いただけますでしょうか?

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <!-- EN-Revision: af6fdf16ab44bcf4d045407963e43c3d9dd2ff29 Maintainer: takagi Status: ready --> needs to be updated.

I am guessing it is 89d80c92a1154a2903fff371f0d056bf2ac8ba27 looking at https://doc.php.net/revcheck.php?p=plain&lang=ja&hbp=af6fdf16ab44bcf4d045407963e43c3d9dd2ff29&f=language/control-structures/include-once.xml&c=on

php/doc-en#3790 の反映
および訳の調整
@takaram
Copy link
Contributor Author

takaram commented Oct 26, 2024

@Girgias
Ah, you are right! Thank you :)

@Girgias Girgias merged commit 5b82121 into php:master Oct 26, 2024
1 check failed
@Girgias
Copy link
Member

Girgias commented Oct 26, 2024

The build is broken because #135 needs to be merged (and checked that it properly syncs the COM FAQ)

@takaram takaram deleted the patch-2 branch October 31, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants