Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATETIME系定数の説明の翻訳 #124

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

o0h
Copy link
Contributor

@o0h o0h commented Aug 10, 2024

DATETIMEの定義済み定数に関して英語の文章が残っている箇所があったので、翻訳した記述をあてています。
翻訳の内容は、同等の説明があるPHP: DateTimeInterface - Manualの表現をベースにしています。

Copy link
Contributor

@youkidearitai youkidearitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

翻訳の追加なので @mumumu さんも時間があったら見てもらえると嬉しいです😃

Copy link
Member

@mumumu mumumu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patch ありがとうございます! 🙏

@mumumu mumumu merged commit a2c6704 into php:master Aug 11, 2024
1 check passed
@o0h o0h deleted the fix/reference-datetime-constants branch November 24, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants